chore(gax-internal): inject diagnostic headers conditionally for integration tests#5030
chore(gax-internal): inject diagnostic headers conditionally for integration tests#5030haphungw wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5030 +/- ##
==========================================
- Coverage 92.66% 92.62% -0.04%
==========================================
Files 226 226
Lines 8682 8690 +8
==========================================
+ Hits 8045 8049 +4
- Misses 637 641 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
trace-propagation-e2e-hack
branch
3 times, most recently
from
70feda2 to
e6f0fa9
Compare
haphungw
changed the title
haphungw
force-pushed
the
trace-propagation-e2e-hack
branch
from
e6f0fa9 to
a82b92c
Compare
…gration tests Allows setting generic HTTP/gRPC headers via GOOGLE_CLOUD_TEST_EXTRA_HEADERS.
haphungw
force-pushed
the
trace-propagation-e2e-hack
branch
from
a82b92c to
2c4412f
Compare
There was a problem hiding this comment.
I would wait until Spanner Client Library has some public interfaces before checking in changes relating to e2e testing of trace propagation with Spanner. As long as you need to test with a fork or staged PR, the fork or PR might as well contain this change.
Another solution if we get uncomfortable with manual testing before spanner stabilizes might be to add a new feature like #[cfg(google_cloud_spanner_for_trace_test)] in the Spanner client library that (1) reexports needed spanner APIs and (2) hardcodes the header configuration in their client library.
|
included in #5031. |
2 participants
Add a test-only environment variable (
GOOGLE_CLOUD_TEST_EXTRA_HEADERS) to generically inject diagnostic headers during execution.